Create capcache64 test, change capcache to RV32 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capcache test was using RV64 instructions without requiring `has_xlen_64`. Create a new test called capcache64 that checks for and uses the RV64 instructions. Change capcache to only use RV32 instructions by changing generators from `gen_rv64_Xcheri_cache` to `gen_rv32_Xcheri_cache`. This follows the same pattern as the float and float64 tests.
|
This is probably a good idea, but for what it's worth I'm currently working on a big overhaul for how architecture requirements get specified and used! |
|
Oh? Sounds good. Shall I close this then? |
|
Feel free to go ahead if this fixes your problem, although I don't see the new rv32 test anywhere? Did it already exist? |
|
Yep, it already existed. Just needed using it seemed. |
PeterRugg
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capcache test was using RV64 instructions without requiring
has_xlen_64.Create a new test called capcache64 that checks for and uses the RV64 instructions.
Change capcache to only use RV32 instructions by changing generators from
gen_rv64_Xcheri_cachetogen_rv32_Xcheri_cache. This follows the same pattern as the float and float64 tests.