Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar in menus and add QoL features related to it #1049

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

souldbminersmwc
Copy link

The grammar in the hekate menus is a bit iffy. I am starting to fix the issues in this PR

@souldbminersmwc
Copy link
Author

This also gives some extra information on certian topics, and adds a few QoL features related to text

@souldbminersmwc souldbminersmwc changed the title Improve grammar in menus Improve grammar in menus and add QoL features related to it Dec 15, 2024
Copy link

@HeikesFootSlave HeikesFootSlave Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many things are really good!
I used some of your changings for my source of hekate that I completely translated into German!

But line 623 doesn't compile in that way you changed it: "123456789 !@#$%^&*()-_=+[]\;'./,{}|:"<>? ");

Problem is the Quotation mark in front of <>? " = Text ends there and compiler gives error!

You should change it so compiler doesn't think it is code instead of text!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants