9-feature-1-user-registration #17
Conversation
…sues that remain are related to persistance, sometimes the accounts are not saved, other times they are.
There was a problem hiding this comment.
I review These classes/interfaces UserVerifier, UserVerificationUI, UserRegUseCase and UserRegistrationUI. I haven't found any issues, and they are following the clean architecture. Nice job!
If I want to add a recommendation, I suggest using different packages to organize user classes. (i.e. for example, a package for tests, interfaces and entities)it makes it easier to follow your codes.
…e" into an object that would either send the code via phone number or email
…possible to add multiple users to the file without issues
There was a problem hiding this comment.
I think the code is well implemented with clean architectures. You implemented Entities, Usecases and UIs. I think it is also great that you have implemented a lot of test cases to make sure your code work as expected. Good Job! One thing that you could consider is maybe to add some more edge cases to your tests, such as cases with empty strings.
| @@ -89,14 +90,6 @@ public List<User> getList() { | |||
| ObjectInputStream in = new ObjectInputStream(fileIn)) { | |||
|
|
|||
| users = (ArrayList<User>) in.readObject(); | |||
| /* | |||
| while(true){ | |||
There was a problem hiding this comment.
I think it is correct to delete this while loop since it is not necessary
src/test/java/UserDatabaseTest.java
Outdated
| UserDatabase accountDatabase = new UserDatabase(accounts); | ||
| accountDatabase.createUser("MeenakshiGopakumar", "123", "[email protected]", "Basic"); | ||
| List<User> lst = accountDatabase.getList(); | ||
| String email = lst.get(0).getEmail(); | ||
| System.out.println(email); | ||
| Assertions.assertTrue(email.equals("[email protected]")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe we can do another test with edge cases that contains empty informations (e.g. "" for email)
Madhavan7
dismissed stale reviews from sogolsahebi, emma0925, and ghost
via
a6d0b75
No description provided.