-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] (Point,PhoneNumber)primitive value -> VO Class #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
============================================
- Coverage 92.82% 91.64% -1.18%
- Complexity 369 374 +5
============================================
Files 72 74 +2
Lines 850 862 +12
Branches 23 24 +1
============================================
+ Hits 789 790 +1
- Misses 47 58 +11
Partials 14 14
|
dojinyou
reviewed
Dec 23, 2023
dojinyou
reviewed
Dec 23, 2023
src/main/kotlin/com/mjucow/eatda/common/vo/deseializer/Latitude.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/common/vo/deseializer/Latitude.kt
Outdated
Show resolved
Hide resolved
dojinyou
requested changes
Jan 9, 2024
dojinyou
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네이밍 수정하고 범위만 줄이고 머지해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 PR이 어떤 것을 하나요?
Point의 latitude와 longitude를 Double값으로 바로 받는 것이 아닌 Latitude ,Longitude의 value class로 받게 했다.
PhoneNumber 같은 경우는 Data class로 불변과 equals, hashjCode의 재정의가 이미 되어있어, 정규표현식에서 번호가 3인 것 까지 받게만 변경하였다.
고민(선택)
기획 문서 혹은 태스크 관련 링크