-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] notice 관련 기능 구현 #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cateogry pr 참고해서 update하고 다시 리뷰 요청해주세연
src/main/kotlin/com/mjucow/eatda/domain/notice/entity/Notice.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/NoticeCommandService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/NoticeCommandService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/dto/UpdateNoticeCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/presentation/store/category/CategoryController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/dto/CreateNoticeCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/NoticeCommandService.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
============================================
+ Coverage 89.15% 90.90% +1.75%
- Complexity 177 213 +36
============================================
Files 30 38 +8
Lines 332 396 +64
Branches 11 12 +1
============================================
+ Hits 296 360 +64
Misses 26 26
Partials 10 10
|
@Column(nullable = false) | ||
var title: String = "" | ||
set(value) { | ||
validateValue(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title
은 길이 제한에 대해서도 검증이 되어야 할 것 같음!
src/main/kotlin/com/mjucow/eatda/domain/notice/service/command/NoticeCommandService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/query/NoticeQueryService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/query/NoticeQueryService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/notice/service/query/dto/NoticeDto.kt
Outdated
Show resolved
Hide resolved
…/NoticeCommandService.kt Co-authored-by: 유도진 <[email protected]>
…oticeQueryService.kt Co-authored-by: 유도진 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci 깨지는 것만 정리하고 squash merge ㄱㄱ
해당 PR이 어떤 것을 하나요?
고민(선택)
기획 문서 혹은 태스크 관련 링크