Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Replaced poetry with uv #429

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

sschleemilch
Copy link
Collaborator

@sschleemilch sschleemilch commented Nov 11, 2024

Poetry -> UV

Why?

  • Way faster
  • Can also install/handle Python versions
  • No change for consumers
  • Should simplify contributor's "does not work on my machine" effects due to the feature of being able to use bundled fresh python installations. Easy to switch python versions very fast

Changes

  • Switched from poetry to nox
  • Added nox with uv backend to run tests for Python versions 3.10 and 3.13 (not testing 3.11 and 3.12 due to time/benefit tradeoff)
  • Removed flake8, which is covered by ruff.
  • Added hatch as build backend, since uv does not provide one

Migration

When this is merged, Contributors will need to do:

  • Install uv
  • Remove the old .venv: rm -rf .venv
  • Create a new one with uv: uv sync
  • Keep working

@sschleemilch sschleemilch force-pushed the feature/poetry-to-uv branch 3 times, most recently from a8242d1 to 7c6bb8e Compare November 11, 2024 13:27
- Way faster
- Can also install/handle Python versions

Signed-off-by: Sebastian Schleemilch <[email protected]>
README.md Outdated Show resolved Hide resolved
- Also removed flake8, covered by ruff
- Testing major Python versions 3.10-3.13

Signed-off-by: Sebastian Schleemilch <[email protected]>
@erikbosch
Copy link
Collaborator

MoM:

  • Please review
  • Can be merged next week if no comments or outstanding discussions/remarks.

Copy link
Collaborator

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did some tests locally.

When merged I can add some words in the wiki on how to update dependencies with uv lock -U

Will wait with merging until Monday in case someone else wants to review

@erikbosch erikbosch merged commit eae6f36 into COVESA:master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants