Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit handling #307

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update unit handling #307

merged 1 commit into from
Nov 22, 2023

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Nov 9, 2023

This refactors unit handling so that it keeps supporting old format but also supports format in
COVESA/vehicle_signal_specification#669.

  • It only focus on keeping existing functionality.
  • No functionality for parsing and verifying domains added.
  • It also does some general cleanup, removing some reverse lookup functionality and slight renaming of classes

@erikbosch erikbosch force-pushed the erik_unit branch 3 times, most recently from eaf74e0 to 6ebf102 Compare November 9, 2023 08:47
@erikbosch erikbosch force-pushed the erik_unit branch 2 times, most recently from 4313545 to 68e3366 Compare November 15, 2023 09:20
@erikbosch erikbosch marked this pull request as ready for review November 21, 2023 12:16
This refactors unit handling so that it keeps supporting old format
but also supports format in
COVESA/vehicle_signal_specification#669.

It only focus on keeping existing functionality.
No functionality for parsing and verifying domains added.

Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch erikbosch merged commit 152a372 into COVESA:master Nov 22, 2023
5 checks passed
@erikbosch erikbosch deleted the erik_unit branch November 22, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant