-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonschema exporter for VSS. #296
Conversation
vspec/vssexporters/vss2jsonschema.py
Outdated
} | ||
|
||
def add_arguments(parser: argparse.ArgumentParser): | ||
parser.description = "The JSON schema exporter does not support any additional arguments." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we possibly have --json-pretty
similar to vspec2json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess it should work same as for JSON.
Here is an OpenAPI example as well
|
Meeting notes:
|
8c7b64c
to
a51e968
Compare
Commit sha: 0dc6a7f, Author: Adnan Bekan, Committer: Adnan Bekan; The sign-off is missing. |
a51e968
to
6909d58
Compare
Two things I would like to have before merging it:
Another topic - do we want it to be included as a future release artifact? If so we should better update https://github.com/COVESA/vehicle_signal_specification/wiki/Release-Instructions-and-Checklist#create-output-artifacts and possibly the VSS Makefile as well to include it in builds/releases, but that can be done after this PR is merged |
I agree on the tests and setup.py, currently however I do think this tool does not work correctly yet. It seems to create something that is almost but not entirely unlike a json schema Investigating |
978de45
to
f1f94bf
Compare
The code dod not work with models that do not have |
ff9bc2f
to
3ecf132
Compare
Added basic tests |
Here i was
Was thinking about this one even in the case if you are defining API for only specific domain. Great. |
Signed-off-by: Adnan Bekan <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]> Signed-off-by: Adnan Bekan <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]> Signed-off-by: Adnan Bekan <[email protected]>
Signed-off-by: Adnan Bekan <[email protected]>
…lidation Signed-off-by: Adnan Bekan <[email protected]>
Signed-off-by: Adnan Bekan <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
c462cc8
to
4c6fd86
Compare
Meeting notes:
|
Signed-off-by: Sebastian Schildt <[email protected]>
Added documentation.
Will investigate |
Did not try that option. Could it be space where it was defined, maybe we have some overlapping with other tools? |
Well. It works..... I think I mixed up some files when checking before. Marking this ready to review (or merge imo) |
Meeting notes:
|
* Add jsonschema exporter for VSS. Signed-off-by: Adnan Bekan <[email protected]> Signed-off-by: Sebastian Schildt <[email protected]>
* Add jsonschema exporter for VSS. Signed-off-by: Adnan Bekan <[email protected]> Signed-off-by: Sebastian Schildt <[email protected]>
Work still in progress.
to try,
./vspec2jsonschema.py ../spec/VehicleSignalSpecification.vspec ../../mydemo.schema.json