BFD-3665 #2512
Draft
BFD-3665 #2512
+976
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahiFentaye
force-pushed
the
BFD-3665
branch
from
cd716cc to
ec14071
Compare
MahiFentaye
force-pushed
the
BFD-3665
branch
from
f750fdc to
c2c5921
Compare
BFD-3665 updating comments
| Set<String> tagCodes = new HashSet<>(); | ||
|
|
||
| String sql; | ||
| if (FissTag.class.equals(tagClass) || McsTag.class.equals(tagClass)) { |
There was a problem hiding this comment.
Do we need the conditional here? These branches look identical.
BFD-3665 moving security tag check to before building transformClaim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BFD-3665 first draft at getting security tags for claim
JIRA Ticket:
BFD-XXXX
What Does This PR Do?
Replace me.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.