-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-3664: Pipeline job for SAMHSA tag backfill. #2506
Draft
dondevun
wants to merge
37
commits into
feature/samhsa2.0
Choose a base branch
from
BFD-3664
base: feature/samhsa2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,526
−26
Draft
Changes from 29 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
c623eb5
Rebased commit for CCW RIF ingestion tag creation.
dondevun 15a7958
Update apps/bfd-model/bfd-model-rif/src/main/java/gov/cms/bfd/model/r…
dondevun 99a9bda
Refactor SamhsaUtil to combine a lot of the logic.
dondevun 1d5206b
Refactor CCW Samhsa ingestion.
dondevun 4e5c249
Fix broken table field in samhsa adapters.
dondevun ec53538
Refactor samhsa adapters
dondevun 18754ba
Removed erroneous file
dondevun e2f5960
Refactored the way SAMHSA methods are executed.
dondevun 88219b4
Removed unused documentation for throws.
dondevun da7848f
Added boolean on SamhsaUtil to indicate if a tag was created.
dondevun 56351c9
Add javadoc for return statement in SamhsaUtil
dondevun c4a82dd
Create pipeline job to backfill SAMHSA data.:
dondevun b5c3a2b
Add configuration for backfill pipeline.
dondevun 69bc595
Move majority of CCW Samsha tag processing to adapters.
dondevun 42535d5
Rearrange methods in SamhsaUtil.
dondevun ead04dc
Update backfill query to ignore claims that already have tags.
dondevun 67f26a4
Formatting changes
dondevun 52da6dd
Merge branch 'feature/samhsa2.0' into BFD-3664
dondevun e978d0a
Fix formatting.
dondevun b3a9b15
Create ability for the backfill to restart where it left off if inter…
dondevun 2ff48dc
Clean up switch statement in getClaimId methods.
dondevun 87f2de9
Fixed checkstyle violation.
dondevun c84a48e
Create integration test for backfill service.
dondevun 6ae26d1
Changes to Samhsa backfill service to reuse same entityManager throug…
dondevun a56f290
Update apps/bfd-pipeline/bfd-pipeline-shared-utils/src/main/java/gov/…
dondevun 85507f4
Fix bug in transaction usage
dondevun fda77ee
Each table will now be processed in its own thread.
dondevun e8d4868
Sum totals of all callable return values using lambdas
dondevun e11f2dc
Refactor backfill to use enums.
dondevun 4d6954d
Using Query instead of NativeQuery
dondevun eb0f047
Testing omitting the not exists statement in the queries
dondevun 068c4fc
Refactor code to query codes from tables directly.
dondevun 9a6f719
Refactor CCW Samhsa backfill to use SQL queries.
dondevun ab6b9f7
Fix null value for appStateCcw
dondevun 3373f25
Added new fields to progress table.
dondevun e17bfd3
Refactor backfill sql
dondevun b75b481
Refactor backfil query
dondevun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
...odel-rif/src/main/resources/db/migration/V20241204194104255__create_backfill_progress.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
CREATE TABLE IF NOT EXISTS ccw.samhsa_backfill_progress ( | ||
claim_table CHARACTER VARYING, | ||
last_processed_claim CHARACTER VARYING, | ||
PRIMARY KEY(claim_table) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ipeline-shared-utils/src/main/java/gov/cms/bfd/pipeline/sharedutils/model/TableEntry.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package gov.cms.bfd.pipeline.sharedutils.model; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
import lombok.Setter; | ||
|
||
/** POJO to contain information about the tables to use in the backfill SQL queries. */ | ||
@Getter | ||
@Setter | ||
@AllArgsConstructor | ||
public class TableEntry { | ||
/** The claim table. */ | ||
String claimTable; | ||
|
||
/** The class of the claim. */ | ||
Class claimClass; | ||
|
||
/** The tag table associated with this claim. */ | ||
String tagTable; | ||
|
||
/** The column that contains the claim id. */ | ||
String claimColumnName; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit confusing that this runs on the RDA pipeline, but I understand the reasoning. Ideally this could run as its own pipeline, but that would increase the complexity a fair bit. I think this is fine for now and we can revisit once we're running in ECS.