-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-3084: Remove Stateless Terraform Modules, Child Modules #2126
Merged
billiedoescode
merged 37 commits into
master
from
br/bfd-3084-remove-stateless-tf-modules
Jan 25, 2024
Merged
BFD-3084: Remove Stateless Terraform Modules, Child Modules #2126
billiedoescode
merged 37 commits into
master
from
br/bfd-3084-remove-stateless-tf-modules
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiedoescode
force-pushed
the
br/bfd-3084-remove-stateless-tf-modules
branch
from
January 4, 2024 17:08
e75fb00
to
6b2f4c7
Compare
billiedoescode
force-pushed
the
br/bfd-3084-remove-stateless-tf-modules
branch
from
January 4, 2024 17:13
6b2f4c7
to
c406e97
Compare
…server_log_alarms
…server_slo_alarms
…server_disk_alarms
…service, restrict to non-ephemeral environments
billiedoescode
force-pushed
the
br/bfd-3084-remove-stateless-tf-modules
branch
from
January 22, 2024 17:37
d275030
to
968bd89
Compare
malessi
previously approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After pairing through the terraform plan
with Billie and verifying everything looks good and there's no unexpected changes, this looks good to me. It's about time we get rid of this dead code 😃.
Base automatically changed from
br/bfd-3083-remove-stateful-tf-modules
to
master
January 25, 2024 17:21
billiedoescode
requested review from
keithdadkins,
mjburling and
brandoncruz3
as code owners
January 25, 2024 19:48
malessi
approved these changes
Jan 25, 2024
mjburling
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3084
User Story or Bug Summary:
As a BFD engineer, I want to remove the stateless terraform module so that we can more easily and succinctly apply changes to our terraservices.
What Does This PR Do?
Move stateless terraform resources into their respective terraservice(s).
This PR is part 2 of removing the stateful and stateless terraform modules and moving away from that design paradigm to better organize our terraservices. It will also require removing the tfstate for our established environments (
test
,prod-sbx
, andprod
) and moving the remaining, necessary resources into their respective terraservice(s) where possible.After this PR is accepted, we will transfer the state of the appropriate terraform resources OOB.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A
If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
What Needs to Be Merged and Deployed Before this PR?
This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:
Submitter Checklist
I have gone through and verified that...:
BFD-123: Adds foo
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.