Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3084: Remove Stateless Terraform Modules, Child Modules #2126

Merged
merged 37 commits into from
Jan 25, 2024

Conversation

billiedoescode
Copy link
Contributor

@billiedoescode billiedoescode commented Jan 3, 2024

JIRA Ticket:
BFD-3084

User Story or Bug Summary:

As a BFD engineer, I want to remove the stateless terraform module so that we can more easily and succinctly apply changes to our terraservices.


What Does This PR Do?

Move stateless terraform resources into their respective terraservice(s).
This PR is part 2 of removing the stateful and stateless terraform modules and moving away from that design paradigm to better organize our terraservices. It will also require removing the tfstate for our established environments (test, prod-sbx, and prod) and moving the remaining, necessary resources into their respective terraservice(s) where possible.

After this PR is accepted, we will transfer the state of the appropriate terraform resources OOB.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Verify all PR security questions and checklists have been completed and addressed.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A

    • Does this PR add any new software dependencies?
      • Yes
      • No
    • Does this PR modify or invalidate any of our security controls?
      • Yes
      • No
    • Does this PR store or transmit data that was not stored or transmitted before?
      • Yes
      • No
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.

    • Do you think this PR requires additional review of its security implications for other reasons?
      • Yes
      • No

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:

  • N/A

Submitter Checklist

I have gone through and verified that...:

  • I have named this PR and branch so they are automatically linked to the (most) relevant Jira issue. Ie: BFD-123: Adds foo
  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • The data dictionary has been updated with any field mapping changes, if any were made.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. DC GEO, BB2, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@billiedoescode billiedoescode force-pushed the br/bfd-3084-remove-stateless-tf-modules branch from e75fb00 to 6b2f4c7 Compare January 4, 2024 17:08
@billiedoescode billiedoescode force-pushed the br/bfd-3084-remove-stateless-tf-modules branch from 6b2f4c7 to c406e97 Compare January 4, 2024 17:13
@billiedoescode billiedoescode force-pushed the br/bfd-3084-remove-stateless-tf-modules branch from d275030 to 968bd89 Compare January 22, 2024 17:37
malessi
malessi previously approved these changes Jan 24, 2024
Copy link
Contributor

@malessi malessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After pairing through the terraform plan with Billie and verifying everything looks good and there's no unexpected changes, this looks good to me. It's about time we get rid of this dead code 😃.

Base automatically changed from br/bfd-3083-remove-stateful-tf-modules to master January 25, 2024 17:21
@billiedoescode billiedoescode dismissed malessi’s stale review January 25, 2024 17:21

The base branch was changed.

@billiedoescode billiedoescode marked this pull request as ready for review January 25, 2024 19:48
@billiedoescode billiedoescode enabled auto-merge (squash) January 25, 2024 19:51
@billiedoescode billiedoescode merged commit 521c22f into master Jan 25, 2024
17 checks passed
@billiedoescode billiedoescode deleted the br/bfd-3084-remove-stateless-tf-modules branch January 25, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants