Carl/bcda 8596 root cause fixes #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A-8596-root-cause-fixes
This reverts commit 75fb669.
carlpartridge
commented
Dec 21, 2024
bhagatparwinder
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8596
🛠 Changes
Revert worker client transport options that were causing large scale restarts. Adjust a few odds and ends with the job reworks to make things clearer.
ℹ️ Context
There was an incident related to jobs being stuck in an infinite loop of sending successful requests to BFD. It seems like what was happening under the hood was that requests were happening, then at some point before finishing, the worker instance would restart. I am 95% sure this is related to the transport config.
🧪 Validation
Tested and linted locally, deployed branch to test env where the same issue was happening and is now resolved.