- Buildeploy.targets: creation of nuget packages not only by providin… #1
Conversation
…g a nuspec file but also by providing a csproj file.
|
Hope the line endings are now ok. |
…resolving assemblies paths for redistribution
…avoid the chicken or the egg problem
… token name is the original token name used by nuget for package identifier
| protected override IPackageArchive CreatePackageArchive() | ||
| { | ||
| var archive = new NugetArchive(NugetExePath, Path.GetFullPath(NuspecFile), OutputDirectory, Version, Log); | ||
| if (!string.IsNullOrWhiteSpace(PackageId)) | ||
| archive.AddProperty("PackageId", PackageId); | ||
| archive.AddProperty("Id", PackageId); |
There was a problem hiding this comment.
This would break existing projects. Please add also the PackageId property.
| PushLocation="%(OctoConfig.PushLocation)" | ||
| ApiKey="%(OctoConfig.ApiKey)" | ||
| /> | ||
| <Copy SourceFiles="$(VersionRedistRoot)\ClickOnce\$(ClickOnceFilePrefix)%(OctoConfig.Identity)_$(Version).zip" |
There was a problem hiding this comment.
Why you deleted the copy commands?
There was a problem hiding this comment.
Deleted copy commands are in my opinion copy / pasted commands which are exactly the same as used inside ClickOnce target. That's why i thought, their presence in the OctoPackage Target is a mistake, causing files to be copied two times, if they would be generated.
There was a problem hiding this comment.
OctoPackage is not related to ClickOnce.
On Sat, Jun 20, 2015 at 7:46 PM Alexander Powolozki <
[email protected]> wrote:
In Buildeploy.targets
#1 (comment):
MinimumRequiredVersion="%(OctoConfig.MinimumRequiredVersion)"RequireLatestVersion="%(OctoConfig.RequireLatestVersion)"Version="$(Version)"TargetFramework="$(ClickOnceTargetFramework)"CreateDesktopShortcut="%(OctoConfig.CreateDesktopShortcut)"IconFile="%(OctoConfig.IconFile)"WebsiteBasePath="$(CompiledSite)"CombineWithWebsite="%(OctoConfig.CombineWithWebsite)"WebsiteFiles="@(CompiledSiteWithConfig)"LinkAssembliesWithManifestAsFile="$(ClickOnceLinkAssembliesWithManifestAsFile)"SkipClickOnce="%(OctoConfig.SkipClickOnce)"PackageId="%(OctoConfig.PackageId)"PushLocation="%(OctoConfig.PushLocation)"ApiKey="%(OctoConfig.ApiKey)"/>- <Copy SourceFiles="$(VersionRedistRoot)\ClickOnce$(ClickOnceFilePrefix)%(OctoConfig.Identity)_$(Version).zip"
Deleted copy commands are in my opinion copy / pasted commands which are
exactly the same as ised during ClickOnce job. That's why i thought, their
presence in the OctoPackage Target is a mistake, causing files to be copied
two times, if they would be generated.—
Reply to this email directly or view it on GitHub
https://github.com/CMSSudhaus/buildeploy/pull/1/files#r32886411.
There was a problem hiding this comment.
Exactly, you are absolutly right!
The copy comands do deploy generated clickonce packages. This deployment is absolutely wrong place insde the OctoPackage target and is already done inside the ClickOnce target.
There was a problem hiding this comment.
And When the ClickOnce Target never invoked? Who will copy
ServerRedistFiles?
On Sat, Jun 20, 2015 at 7:59 PM Alexander Powolozki <
[email protected]> wrote:
In Buildeploy.targets
#1 (comment):
MinimumRequiredVersion="%(OctoConfig.MinimumRequiredVersion)"RequireLatestVersion="%(OctoConfig.RequireLatestVersion)"Version="$(Version)"TargetFramework="$(ClickOnceTargetFramework)"CreateDesktopShortcut="%(OctoConfig.CreateDesktopShortcut)"IconFile="%(OctoConfig.IconFile)"WebsiteBasePath="$(CompiledSite)"CombineWithWebsite="%(OctoConfig.CombineWithWebsite)"WebsiteFiles="@(CompiledSiteWithConfig)"LinkAssembliesWithManifestAsFile="$(ClickOnceLinkAssembliesWithManifestAsFile)"SkipClickOnce="%(OctoConfig.SkipClickOnce)"PackageId="%(OctoConfig.PackageId)"PushLocation="%(OctoConfig.PushLocation)"ApiKey="%(OctoConfig.ApiKey)"/>- <Copy SourceFiles="$(VersionRedistRoot)\ClickOnce$(ClickOnceFilePrefix)%(OctoConfig.Identity)_$(Version).zip"
Exactly, you are absolutly right!
The copy comands do deploy generated clickonce packages. This deployment
is absolutely wrong place insde the OctoPackage target and is already done
inside the ClickOnce target.—
Reply to this email directly or view it on GitHub
https://github.com/CMSSudhaus/buildeploy/pull/1/files#r32886518.
There was a problem hiding this comment.
I think this should be extracted into separate Target which should be invoked in the same manner like ClickOnce and OctoPackage.
- Refactoring of preparation and redistribution of binaries to be able to add and check additional binaries by probject
Allow to create nuget packages not only by providing a nuspec file but also by providing a project file. This automaticaly includes all dependent packages into the incorporated nuspec file and all references, which could not be resolved as nuget packages will be included as referenced assemblies.