Finish delete and update repo, and delete user #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaiser-Yang
force-pushed
the
kaiser-crud
branch
from
5c91cca to
7616a8d
Compare
We finish the APIs for deleting and updating repository. For the deleting user API, we now will remove all the ssh-keys uploaded by the user, but not the repositories. Besides, we find that we should not trust the data from the client side, such as the `userId` from request body, we must get this data from the database to check if the operation is allowed. See #20 and #32.
Kaiser-Yang
force-pushed
the
kaiser-crud
branch
from
6e57401 to
821025b
Compare
luckygalaxy666
approved these changes
Sep 25, 2024
ajiankexx
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finish the APIs for deleting and updating repository. For the deleting user API, we now will remove all the ssh-keys uploaded by the user, but not the repositories.
Besides, we find that we should not trust the data from the client side, such as the
userIdfrom request body, we must get this data from the database to check if the operation is allowed.See #20 and #32.