Add an api for updating user information #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaiser-Yang
force-pushed
the
kaiser-crud
branch
2 times, most recently
from
c03485f to
f1d97b7
Compare
During development, we found that the `Long` can not be expressed correctly in the `Swagger` document, so we use `String` to represent the `id` and convert it to `Long` when we use it as the field of `UserPO`. We also found that the `HttpServletRequest`'s `getReader()` and `getInputStream()` can only be called once, so we need to cache the request body in the `JwtFilter` to make it can be read multiple times. During this commit, we update the header parameter `Token` with the `Access-Token` and `Refresh-Token` to make it more clear. See #32.
Kaiser-Yang
force-pushed
the
kaiser-crud
branch
from
2bc931d to
9a275ca
Compare
Kaiser-Yang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development, we found that the
Longcan not be expressed correctly in theSwaggerdocument, so we useStringto represent theidand convert it toLongwhen we use it as the field ofUserPO.We also found that the
HttpServletRequest'sgetReader()andgetInputStream()can only be called once, so we need to cache the request body in theJwtFilterto make it can be read multiple times.During this commit, we update the header parameter
Tokenwith theAccess-TokenandRefresh-Tokento make it more clear.See #32.