Add command_checker and setup_logger to script/deploy_helper.py #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajiankexx
commented
Jul 31, 2024
ajiankexx
commented
- Add command_checker function to verify command execution.
- Add setup_logger function to configure the logging system.
- Replace some code with command_checker.
ajiankexx
changed the title
ajiankexx
changed the title
Kaiser-Yang
added
the
project initialization
ajiankexx
force-pushed
the
nt-dev
branch
2 times, most recently
from
d6fe352 to
9a395e8
Compare
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
In script/deploy_helper.py, add two functions named command_checker and setup_logger. And substitute some code with command_checker.Below are their functions: - Add command_checker function to check if a command execute successfully. If executing failed, command_checker will output error log and status code. If executing successfully, nothing will happen. - Add setup_logger function to configure the logging system. It will create a logger object and set the log level to INFO. Also, user can set the log level using --log-level option. - Replace some code like 'res=...if res!=0' with command_checker. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
- Modify the format of the log message in command_checker to improve readability - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0 - Add support for setting log level of setup_logger when executing deploy_helper.py in shell Resolves: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
- Modify the format of the log message in command_checker to improve readability - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0 - Add support for setting log level of setup_logger when executing deploy_helper.py in shell Resolves: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
Translate original Chinese comments in command_checker and setup_logger in script/deploy_helper.py into English. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
- Modify the format of the log message in command_checker to improve readability - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0 - Add support for setting log level of setup_logger when executing deploy_helper.py in shell Resolves: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
In script/deploy_helper.py, add two functions named command_checker and setup_logger. And substitute some code with command_checker.Below are their functions: - Add command_checker function to check if a command execute successfully. If executing failed, command_checker will output error log and status code. If executing successfully, nothing will happen - Add setup_logger function to configure the logging system. It will create a logger object and set the log level to INFO. Also, user can set the log level using --log-level option - Replace some code like 'res=...if res!=0' with command_checker See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
Translate original Chinese comments in command_checker and setup_logger in script/deploy_helper.py into English See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 1, 2024
- Modify the format of the log message in command_checker to improve readability - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0 - Add support for setting log level of setup_logger when executing deploy_helper.py in shell Resolves: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 2, 2024
In script/deploy_helper.py, add two functions named command_checker and setup_logger. And substitute some code with command_checker.Below are their functions: - Add command_checker function to check if a command execute successfully. If executing failed, command_checker will output error log and status code. If executing successfully, nothing will happen. - Add setup_logger function to configure the logging system. It will create a logger object and set the log level to INFO. Also, user can set the log level using --log-level option. - Replace some code like 'res=...if res!=0' with command_checker. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 2, 2024
Translate original Chinese comments in command_checker and setup_logger in script/deploy_helper.py into English. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 2, 2024
- Modify the format of the log message in command_checker to improve readability. - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0. - Add support for setting log level of setup_logger when executing deploy_helper.py in shell. Resolves: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 2, 2024
- Modify the format of the log message in command_checker to improve readability. - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0. - Add support for setting log level of setup_logger when executing deploy_helper.py in shell. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 2, 2024
- Add the current file name in the output log. - Modify the behavior of command_checker. Now it will only output the content in parameter of message. - Add command_checker for each call of os.system(). - Use """ """ instead of " " to output log. Resolves: #17
In script/deploy_helper.py, add two functions named command_checker and setup_logger. And substitute some code with command_checker.Below are their functions: - Add command_checker function to check if a command execute successfully. If executing failed, command_checker will output error log and status code. If executing successfully, nothing will happen. - Add setup_logger function to configure the logging system. It will create a logger object and set the log level to INFO. Also, user can set the log level using --log-level option. - Replace some code like 'res=...if res!=0' with command_checker. See: #17
Translate original Chinese comments in command_checker and setup_logger in script/deploy_helper.py into English. See: #17
- Modify the format of the log message in command_checker to improve readability. - Delete parameter 0 in each call of command_checker when the parameter expected status code is 0. - Add support for setting log level of setup_logger when executing deploy_helper.py in shell. See: #17
- Add information of developer ajiankexx to pom.xml See: #12
ajiankexx
added a commit
that referenced
this pull request
Aug 4, 2024
- Add the current file name in the output log. - Modify the behavior of command_checker. Now it will only output the content in parameter of message. - Add command_checker for each call of os.system(). - Use """ """ instead of " " to output log. Resolves: #17
- Add the current file name in the output log. - Modify the behavior of command_checker. Now it will only output the content in parameter of message. - Add command_checker for each call of os.system(). - Use """ """ instead of " " to output log. See: #17
ajiankexx
added a commit
that referenced
this pull request
Aug 8, 2024
- Add support for showing the line number of the command_checker to help the user to find which command failed. - Modify the format how the log is printed. - Add two vars message_tmp and command to store the template of the message and the command to be executed respectively. It will make codes more readable and easier to understand. Resolves: #17
- Add support for showing the line number of the command_checker to help the user to find which command failed quickly. - Modify the format how the log is printed. - Add two vars message_tmp and command to store the template of the message and the command to be executed respectively. It will make codes more readable and easier to understand. Resolves: #17
Kaiser-Yang
approved these changes
Aug 8, 2024
luckygalaxy666
approved these changes
Aug 8, 2024
luckygalaxy666
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.