Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip an inaccessible database at agent startup #46

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

dbulashev
Copy link

No description provided.

@CHERTS
Copy link
Owner

CHERTS commented Oct 21, 2024

I think we should make an additional option, like test_db_connection_on_startup = true
This way, by default, we test the database connection and do not break backward compatibility.
It is probably important for some users to terminate the service if the database is not available.
If we disable this option (test_db_connection_on_startup = false), then pgSCV will start even if the database is not available at startup.

@CHERTS
Copy link
Owner

CHERTS commented Oct 29, 2024

I made a slight mistake in the logic of checking the connection to the database, the variable is logically called skip_conn_error_mode and by default it will be false

@CHERTS CHERTS merged commit 47e69a0 into CHERTS:master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants