Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ambiguous overloaded function argument #497

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Resolve ambiguous overloaded function argument #497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d93e44b
Resolve ambiguous overloaded function argument
myclevorname Oct 16, 2024
66f5e18
Change the hacky cast to an initializer
myclevorname Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gui/qt/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,7 @@
DockWidget *MainWindow::redistributeFindDock(const QPoint &pos) {
QWidget *child = childAt(pos);
if (QTabBar *tabBar = findSelfOrParent<QTabBar *>(child)) {
child = childAt({pos.x(), tabBar->mapTo(this, QPoint{}).y() - 1});
child = childAt(QPoint({pos.x(), tabBar->mapTo(this, QPoint{}).y() - 1}));
}
return findSelfOrParent<DockWidget *>(child);
}
Expand Down Expand Up @@ -2018,7 +2018,7 @@
QAbstractButton *buttonCopyVersion = aboutBox->addButton(tr("Copy version"), QMessageBox::ActionRole);
// Needed to prevent the button from closing the dialog
buttonCopyVersion->disconnect();
connect(buttonCopyVersion, &QAbstractButton::clicked, this, [this, buttonCopyVersion](){ QApplication::clipboard()->setText("CEmu " CEMU_VERSION " (git: " CEMU_GIT_SHA ")", QClipboard::Clipboard); buttonCopyVersion->setEnabled(false); buttonCopyVersion->setText(tr("Version copied!")); });

Check warning on line 2021 in gui/qt/mainwindow.cpp

View workflow job for this annotation

GitHub Actions / Build: macos-12 Qt5_intel 

lambda capture 'this' is not used [-Wunused-lambda-capture]

QAbstractButton *okButton = aboutBox->addButton(QMessageBox::Ok);
okButton->setFocus();
Expand Down
Loading