Ruby, elasticsearch upgrades, and documentation #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adds documentation for new changes, closes #208 |
wkdewey
force-pushed
the
ruby3upgrade
branch
2 times, most recently
from
dd8d51f
to
d4a8144
Compare
|
Force pushed after rebase removing the duplicate commits from #210 |
techgique
approved these changes
Mar 23, 2023
CHANGELOG.md
Outdated
Comment on lines
37
to
46
| - API schema can either be 1.0 or 2.0 (which includes nested fields); 1.0 will be run by default unless 2.0 is specified. Add the following to `public.yml` or `private.yml` in the data repo: | ||
| ``` | ||
| api_version: '2.0' | ||
| ``` | ||
| - schema validation with API version 2.0, invalidly constructed documents will not post | ||
| - authentication with Elasticesarch 8.5; add the following to `public.yml` or `private.yml` in the data repo: | ||
| ``` | ||
| es_user: username | ||
| es_password: ******** | ||
| ``` |
There was a problem hiding this comment.
Instructions like these to add / edit config files should be in the Migration section. Otherwise the Migration section looks very thorough 👍 I'll have to edit this file for merge conflicts after I updated the changelog file to fix up the last release though. I'll take care of it during review of the release/v1.0.0 branch which will have the merge conflict.
Comment on lines
+42
to
+46
| if get_list(@xpaths["date"]) | ||
| datestr = get_list(@xpaths["date"]).first | ||
| else | ||
| datestr = nil | ||
| end |
There was a problem hiding this comment.
I'd write this more briefly with a ternary, but no need to change it:
datestr = get_list(@xpaths["date"]) ? get_list(@xpaths["date"]).first : nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #205