Added unit tests to the project #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…natureController class
…eController class
…atureController class
…ssage to external service using certificates
…service using certificates
drewjj
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Everything is looking great! These are some great additions for this repository and everything runs perfectly while running the tests through a command line. I did encounter an issue with the ApplicationTest test() test in VSCode. It appears JMockit is not being properly initialized in the Java TestRunner. This might be due to the dev container configuration but it would be good to get this resolved since we do want to include that in this pull request.
drewjj
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are no unit tests implemented for this project.
Solution
Unit tests have been implemented.
New Classes
In order to make the project more testable, the following classes have been introduced to wrap certain operations:
Additionally, the Message class has been moved to its own file.
Typo Correction
The 'certficates' typo has been corrected to 'certificates' across the board.
Testing
Unit tests have been verified to pass & the signing functionality has been verified to work.