Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing USDOT PR Comments 6/11/2024 #24

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Addressing USDOT PR Comments 6/11/2024 #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca277a
Generalized some log statements in AwsDepositor
dmccoystephenson Jun 11, 2024
b2083fb
Added comment regarding GOOGLE_APPLICATION_CREDENTIALS env var
dmccoystephenson Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/us/dot/its/jpo/ode/aws/depositor/AwsDepositor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ public void run(String[] args) throws Exception {
} else if (destination.equals("firehose")) {
firehose = buildFirehoseClient(awsRegion);
} else if (destination.equals("gcs")) {
// The file path specified by GOOGLE_APPLICATION_CREDENTIALS will be used here.
gcsStorage = StorageOptions.getDefaultInstance().getService();
} else {
logger.error("Invalid destination: " + destination);
Expand Down Expand Up @@ -213,8 +214,8 @@ public void run(String[] args) throws Exception {
}
} catch (Exception e) {
int retryTimeout = 5000;
logger.error("Error depositing to AWS. Retrying in " + retryTimeout / 1000 + " seconds",
e);
String destinationName = depositToS3 ? "S3" : destination;
logger.error("Error depositing to destination '" + destinationName + "'. Retrying in " + retryTimeout / 1000 + " seconds", e);
Thread.sleep(retryTimeout);
}
}
Expand All @@ -226,7 +227,7 @@ public void run(String[] args) throws Exception {
}
}
} catch (Exception e) {
logger.error("Server Error. reconnecting to AWS ", e);
logger.error("Server Error. reconnecting to destination ", e);
} finally {
stringConsumer.close();
}
Expand Down
Loading