Optional RSU/SDX TIM Signing #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccoystephenson
requested changes
Mar 21, 2024
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Show resolved
Hide resolved
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Outdated
Show resolved
Hide resolved
payneBrandon
requested changes
Mar 25, 2024
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Outdated
Show resolved
Hide resolved
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Outdated
Show resolved
Hide resolved
dmccoystephenson
approved these changes
Mar 27, 2024
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Outdated
Show resolved
Hide resolved
dmccoystephenson
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Left a comment regarding a potential refactor of the isDataSigningEnabled() method.
Relevant comment: #67 (comment)
dmccoystephenson
requested changes
Apr 2, 2024
dmccoystephenson
approved these changes
Apr 3, 2024
jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/services/asn1/Asn1EncodedDataRouter.java
Outdated
Show resolved
Hide resolved
Comment on lines
+103
to
+108
| if (rsus instanceof JSONObject) { | ||
| JSONObject rsusIn = (JSONObject) request.get(TimTransmogrifier.RSUS_STRING); | ||
| if (rsusIn.has(TimTransmogrifier.RSUS_STRING)) { | ||
| Object rsu = rsusIn.get(TimTransmogrifier.RSUS_STRING); | ||
| JSONArray rsusOut = new JSONArray(); | ||
| if (rsu instanceof JSONArray) { |
There was a problem hiding this comment.
I think it would improve readability and comprehension for the reader if we extracted the blocks of these "if" statements into methods with descriptive names. Also, while it might be less impactful, extracting the conditions being checked into methods with descriptive names could also improve clarity. We should consider implementing these changes at some point.
9 tasks
This was referenced Apr 30, 2024
drewjj
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
These updates allow users to specify whether signing occurs for RSU-delivery TIMs and SDX-delivery TIMs.
Motivation and Context
Previously, signing was either on or off. This update allows for greater flexibility with TIM signing.
How Has This Been Tested?
This change has been tested locally using the /tim endpoint to deposit both RSU-delivery TIMs and SDX-delivery TIMs.
Types of changes
Checklist:
ODE Contributing Guide