Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DOCKER_SHARED_VOLUME_WINDOWS env var #53

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

dmccoystephenson
Copy link
Member

Problem

The DOCKER_SHARED_VOLUME_WINDOWS environment variable is no longer needed.

Solution

The DOCKER_SHARED_VOLUME_WINDOWS environment variable has been removed.

Testing

Spinning up the project using docker-compose has been verified to work with these changes.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this definitely makes things easier to understand.

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It's nice to get that removed to avoid confusion

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 6a57ddb into dev Jan 26, 2024
4 checks passed
@payneBrandon payneBrandon deleted the env/remove-docker-shared-volume-windows branch January 26, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants