Direct PPM_LOG_LEVEL Access and Stalling Prevention #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccoystephenson
changed the title
dmccoystephenson
changed the title
src/ppmLogger.cpp
Outdated
| @@ -13,7 +13,27 @@ PpmLogger::PpmLogger(std::string logname) { | |||
| sinks.push_back(std::make_shared<spdlog::sinks::stdout_sink_mt>()); | |||
| } | |||
| setLogger(std::make_shared<spdlog::logger>("log", begin(sinks), end(sinks))); | |||
|
|
|||
| // use PPM_LOG_LEVEL environment variable to set the log level | |||
| std::string logLevelString = getEnvironmentVariable("PPM_LOG_LEVEL"); | |||
There was a problem hiding this comment.
What happens if the PPM_LOG_LEVEL isn't set? or is set to say a number? When we try toLowercase of those will we run into any issues?
There was a problem hiding this comment.
If PPM_LOG_LEVEL isn't set, the default value will be used. If it is set to a number or anything else unrecognized, the default will also be used. I've added some comments to a few methods to make this clearer.
Since we read environment variables as strings, even if PPM_LOG_LEVEL is set to a number it will be treated as a string, so we won't run into any issues.
payneBrandon
requested changes
Oct 30, 2023
payneBrandon
approved these changes
Oct 30, 2023
dmccoystephenson
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sync master to develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modification in Use of PPM_LOG_LEVEL env var
Previously, the ppm_no_map.sh script referenced the PPM_LOG_LEVEL environment variable and used it to pass the 'v' opt string to the program. This 'v' opt string was then parsed in the 'PPM' class.
With these updates, the PpmLogger now directly accesses the PPM_LOG_LEVEL environment variable, eliminating the necessity for the 'v' opt string.
Manual Setting of PPM_LOG_LEVEL Environment Variable When Running the PPM Container via Scripts
The PPM_LOG_LEVEL has been adjusted to DEBUG in the standalone.sh and standalone_multi.sh scripts.
This adjustment prevents potential stalling issues during the PPM container's readiness checks, which have affected the execution of the
do_kafka_test.shscript.It should be noted that this will not affect the default logging level during regular PPM operation.
Relevant PR Comment
These changes address the following USDOT PR comment:
usdot-jpo-ode#31 (comment)