Changed how you allocate Ram in the launcher from percent to now mb and fix #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…small issue where the system memory was not converetd correctly
1zun4
reviewed
Nov 30, 2024
Comment on lines
+41
to
+42
| #[serde(rename = "systemMemory")] | ||
| pub system_memory: i64, |
There was a problem hiding this comment.
I think you should consider to re-add mem_percentage instead of storing the system memory inside the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the launcher to now use mb to allocate and not do some fancy stuff and there was an small conversion bug right here:
((sys.total_memory() / **1000000**) as f64 * (memory_percentage as f64 / 100.0)) as i64.This is my first pull request so im verry sorry about any errors I made.