Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #82/replace libpopt in rbcavity #89

Merged
merged 24 commits into from
May 3, 2024

Conversation

ggutierrez-sunbright
Copy link
Contributor

@ggutierrez-sunbright ggutierrez-sunbright commented Feb 10, 2024

  • decouple argument parser setup, parsing, entry-point and rbcavity procedure
  • create RbtArgParser.h file with common and helper functions regarding parser setup
  • create RbtPlatformCompatibility.h file to get rid of the "unwieldy" #ifdef ... in the middle of functions. in this case, for ios_base::openmode for input and output.

closes #88

@ggutierrez-sunbright ggutierrez-sunbright self-assigned this Feb 10, 2024
@ggutierrez-sunbright ggutierrez-sunbright added the upgrade a design modification, refactor, or component replacement label Feb 15, 2024
@ggutierrez-sunbright ggutierrez-sunbright added this to the libpopt removal milestone Feb 15, 2024
@ggutierrez-sunbright ggutierrez-sunbright merged commit 50bfe95 into main May 3, 2024
10 checks passed
@ggutierrez-sunbright ggutierrez-sunbright deleted the issue-#82/replace-libpopt-in-rbcavity branch May 3, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade a design modification, refactor, or component replacement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to cxxopts in rbcavity
1 participant