Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESIGN] 동아리 관련 페이지 웹 반응형 디자인 #110

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

selfishAltruism
Copy link
Contributor

🚩 관련 이슈
resolve #109

📋 PR Checklist

  • 동아리 설명 카드 크기 조절
  • 동아리 설명 카드 대표 이미지 배경색 조정
  • 동아리 카드 라우터 에러 해결

📌 유의사항

  • 디자인 팀 결과물 나온 이후 다시 진행 예정

✅ 테스트 결과

image

@selfishAltruism selfishAltruism added fix 올바르지 않은 동작, 버그 수정 design 스타일 코드 작성 labels Mar 21, 2024
@selfishAltruism selfishAltruism self-assigned this Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for causw-develop ready!

Name Link
🔨 Latest commit da5f93f
🔍 Latest deploy log https://app.netlify.com/sites/causw-develop/deploys/65fd0e919215260009e23a56
😎 Deploy Preview https://deploy-preview-110--causw-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for caucse ready!

Name Link
🔨 Latest commit da5f93f
🔍 Latest deploy log https://app.netlify.com/sites/caucse/deploys/65fd0e918caac50008bff561
😎 Deploy Preview https://deploy-preview-110--caucse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85
Accessibility: 84
Best Practices: 92
SEO: 92
PWA: 60
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@selfishAltruism selfishAltruism changed the title Design/#109 [DESIGN] 동아리 관련 페이지 웹 반응형 디자인 Mar 21, 2024
@lee0jae330
Copy link

고생하셨습니다

Copy link
Contributor

@omjinLTS omjinLTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오래걸리는거면 패스

@@ -41,7 +26,7 @@ const CircleHomePage: React.FC = observer(() => {
<Circle.ListFrame
items={circles}
emptyText={'아직 등록된 동아리가 없어요!'}
ListComponent={screenWidth > WEB_WIDTH_CONDITION ? Circle.WebSlider : Circle.Slider}
ListComponent={!isMobile ? Circle.WebSlider : Circle.Slider}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 ! 빼고 앞뒤 순서 바꾸는게 어떰
그리고 차후여도되고 WebSlider / Slider 말고 WebSlider / MobileSlider로 ㄱㄴ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에라도 헷갈릴거같애서

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘 중으로 해볼게유

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 바랍니다 :)

@Ontheway-01
Copy link
Member

굿입니다~

@selfishAltruism selfishAltruism added the docs 문서 추가 및 변경 label Mar 22, 2024
Copy link
Contributor

@omjinLTS omjinLTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selfishAltruism selfishAltruism merged commit 67cd074 into develop Mar 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design 스타일 코드 작성 docs 문서 추가 및 변경 fix 올바르지 않은 동작, 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants