-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DESIGN] 동아리 관련 페이지 웹 반응형 디자인 #110
Conversation
✅ Deploy Preview for causw-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for caucse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
고생하셨습니다 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오래걸리는거면 패스
@@ -41,7 +26,7 @@ const CircleHomePage: React.FC = observer(() => { | |||
<Circle.ListFrame | |||
items={circles} | |||
emptyText={'아직 등록된 동아리가 없어요!'} | |||
ListComponent={screenWidth > WEB_WIDTH_CONDITION ? Circle.WebSlider : Circle.Slider} | |||
ListComponent={!isMobile ? Circle.WebSlider : Circle.Slider} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 ! 빼고 앞뒤 순서 바꾸는게 어떰
그리고 차후여도되고 WebSlider / Slider 말고 WebSlider / MobileSlider로 ㄱㄴ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에라도 헷갈릴거같애서
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오늘 중으로 해볼게유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 바랍니다 :)
굿입니다~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚩 관련 이슈
resolve #109
📋 PR Checklist
📌 유의사항
✅ 테스트 결과