Allow on-disk files to be read using binary mode 'rb' #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SimpleReader under python3 tends to get unhappy when asked to read a binary file from local disk.
The problem is that these files were always opened using 'r' mode, which means that python3 would treat the contents as utf-8 and try to decode whatever it reads into useful text. When the decoding inevitably fails, python3 would throw an exception.
This PR adds an optional
mode
argument to the SimpleReaderinit()
method so that the reader can be forced to open the file in binary mode.wandio_open()
has also been updated to allowrb
as a valid mode, and will pass that on to the Reader init method.Finally, I've also added a
-m
option toread_main()
(akapywandio-cat
) which allows the mode to be specified via CLI argument.