Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Feature multiple states #24

Closed
wants to merge 5 commits into from
Closed

Feature multiple states #24

wants to merge 5 commits into from

Conversation

Chaos99
Copy link
Contributor

@Chaos99 Chaos99 commented Oct 30, 2016

Adds a second state "members_only" to the script for issue #2

  • breaks api (0.13) compatibility, but may be backwards compatible dependent on the client implementation (has to evaluate non-empty string to boolean true)
  • more states may be added based on the new scheme
  • adds new icon
  • adds more information in README
  • second state is not yet set in generate_spaceapi based on any input

@izzy
Copy link
Member

izzy commented Nov 7, 2016

I'm not sure breaking compat with current clients is the way to go, espacially when there's no newer API version. A well-defined API like the spaceapi is well-defined for a reason, so I'd rather see this in the sections where user-defined things like these are actually supported until the spaceapi is changed. (opened a new issue on their github page yet?)

Breaking API compat might work for some clients, but especially in languages with strong typing this might bekome a real problem(read: crashes, undefined behaviour, etc.) - just because we didn't care to use the API properly :/

@Chaos99
Copy link
Contributor Author

Chaos99 commented Nov 8, 2016

Ok. Then lets close this request and start a new one once this is changed in the code.
There is (now ?) more info in the issue description about how to implement.

@Chaos99 Chaos99 closed this Nov 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants