This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Check if ad_integration module exists, before trying to get the service #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite_base.module
Outdated
| @@ -242,7 +242,7 @@ function infinite_base_get_all_parents($term) { | |||
| * Implements hook_preprocess_node(). | |||
| */ | |||
| function infinite_base_preprocess_node(&$variables) { | |||
| if ($variables['view_mode'] == 'full' || $variables['view_mode'] == 'lazyloading') { | |||
| if ($variables['view_mode'] == 'full' || $variables['view_mode'] == 'lazyloading' && \Drupal::moduleHandler()->moduleExists('ad_integration')) { | |||
There was a problem hiding this comment.
this check is wrong, the "&&" operator is binding stronger then the "||" operator, which results in a faulty check, it should be something like this (see additional parenthesis arround the "||" operands):
if ( ($variables['view_mode'] == 'full' || $variables['view_mode'] == 'lazyloading') && \Drupal::moduleHandler()->moduleExists('ad_integration'))
There was a problem hiding this comment.
Yeah, I don't know why I overlooked this. Thanks for the fix.
stevenx
force-pushed
the
8.x-2.x
branch
3 times, most recently
from
82389e6 to
94fda4f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary, because we moved the ad_integration from thunder to the thunder_infrastructure, making it an optional module.