Fix make distcheck and add Travis CI configuration #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Udev rules are hard-coded to /lib install prefix, so distcheck fails. As a workaround, use distcheck flags to override and point to local prefix.
make distcheck fails due to the use of a wildcard to select all headers in src, in EXTRA_DIST. List all individual headers instead to stop the failure.
|
OK, seems good to me, although I know close to nothing about CI and the like. @Lekensteyn Any thoughts? |
|
@Lekensteyn - ping :-) |
|
LGTM, thanks @bluca |
|
Thanks! You'll need to enable the repository on travis-ci.org, I don't have permissions: https://travis-ci.org/profile/Bumblebee-Project You can login with your Github account and then flick the switch. Also, what do you think of releasing tarballs through Travis and Github as I wrote? If you guys are ok with the idea I can send a PR to implement it. |
|
Forgot to enable it, now Travis should work for future PRs and pushes to develop. I am mostly fine with releasing tarballs through Travis and Github. Normally I would run some tests by hand, but that can still be done before tagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ArchangeGabriel @Lekensteyn - As discussed here: #772 (comment) we could upload dist tarballs via Travis directly on Github. We also get a build CI for free :-)
Once it's setup, after pushing a tag on the designated branch you'll automatically get the release and the make dist deploy, and this is how it looks like: https://github.com/bluca/Bumblebee/releases/tag/3.2.1-test
This is the CI build: https://travis-ci.org/bluca/Bumblebee/builds/134895811
If you guys like it, I'll setup Travis for this repository, and create an OAUTH token that can be used. An additional commit will be needed to use those, it will look like this but with different data: bluca@9390eb0