Cohorts section updated in index.tsx #35
Conversation
Updated the Cohorts section replacing the table by a new image. This is my first code change PR (& also writing in a .tsx file) so I hope I didn't mess up the divs annotation or broke anything! I think there's an extra div that we don't need now, that was probably centering the text column with the table or smth, and now that we don't have the table anymore it's probably redundant, but not sure.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Nice Andrea creating a PR! 🙏🙏
I've done some tweaks:
- Deleted all cohorts data logic, since it was not used anymore we were getting lint errors that wouldn't let us update Vercel build
- Tweaked spacings/responsive. Here is the before/after video to check. Could you confirm if you see it OK in mac super high resolution?
- Updated asset names so we don't get caught again by the code police officer :)
The question here is:
- Are we sure we want to delete the cohort table?
- Shouldn't we change the "Supporting up-and-coming high-impact devs" section, since we don't have the open developer streams anymore? Or it's in the works still?
Thanks for the PR Andrea! Love to see you tweaking code and managing PRs, you should install Cursor + AI if you haven't yet, it's a great helper for devs! 🙌
It looks like it, yes. "they are more like internal spending numbers"
Yes, I think the graphic is ready but we still need a new copy for the section. We can do it in another PR when ready-
🤣 |
|
👌 great! Merging! We can tweak in future PR if it doesn't look great in mac. |
|
Hey!
Yes it looks great on mac as well, thanks @Pabl0cks ! And thanks for the support as well 🫶🏻 it's exciting! Gonna fork the repo so it'll works next time, and I'll download Cursor for sure! Will hit you up if I have more doubts :) |
Updated the Cohorts section replacing the table by a new image. This is my first code change PR (& also writing in a .tsx file) so I hope I didn't mess up the divs annotation or broke anything!
I think there's an extra div that we don't need now, that was probably centering the text column with the table or smth, and now that we don't have the table anymore it's probably redundant, but not sure. Also maybe now we need to adjust the width or height, I used the same parameters to similar images in other sections.
Deleted table:
How it should look like now (don't mind the margins):
This addresses changes that were discussed in #34