Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ion input button #873

Conversation

allan-chagas-brisa
Copy link
Contributor

@allan-chagas-brisa allan-chagas-brisa commented Oct 13, 2023

Issue Number

fix #872

Description

Change of the button elements inside the ion input for a single ion button, that can adapt to a icon button or a regular button.

Proposed Changes

  • The two buttons elements were removed ;
  • one ionInputProperty removed, leaving just the inputButton;
  • added the inputButtonConfig property;
  • the ng classes were removed from the input and one was set to the input container;
  • added a ionButton with its main properties;
  • changed the styles to adapt the ion button to this scenario;
  • addapted the tests to the new input button specification;
  • changes on the date-picker to adapt to the new inputButton;

How to Test

yarn test input

View Storybook

Storybook

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

@allan-chagas-brisa allan-chagas-brisa linked an issue Oct 13, 2023 that may be closed by this pull request
@allan-chagas-brisa allan-chagas-brisa self-assigned this Oct 13, 2023
@allan-chagas-brisa allan-chagas-brisa merged commit a4385e4 into main Oct 16, 2023
3 checks passed
@allan-chagas-brisa allan-chagas-brisa deleted the 872-fix-ion-input-button-should-be-a-ion-button-with-its-config branch October 16, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: ion input button should be a ion button with its config
3 participants