-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input select #862
Merged
Merged
Input select #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allan-chagas-brisa
requested review from
iurynogueira,
deeved-hiuston-brisa,
danilo-moreira-brisa and
marcos-assis-brisa
October 6, 2023 13:29
iurynogueira
approved these changes
Oct 10, 2023
projects/ion/src/lib/input-select/input-select.component.spec.ts
Outdated
Show resolved
Hide resolved
jairochaves2
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the new component Input Select, which consists in a input next to a select button with a label that describes its usage.
Proposed Changes
@input() name: string; The property to link the input element with an possible label;
@input() disabled = false; The property to disable the button and the input;
@input() value = ''; The property that holds the value of the first input;
@input() secondValue = ''; The property that holds the value of the second input;
@input() selectOptions: SelectOption[] = defaultSelectOptions; The property where the user passes an array of options, of the type SelectOption, to be displayed on the dropdown from the select component;
@output() valueChange = new EventEmitter(); The emmiter, that emmits an object of the type ValueToEmmit, every time the user inputs in the element;
How to Test
yarn test input-select
Screenshots
Gravacao.de.tela.de.06-10-2023.10.26.36.webm
View Storybook
Storybook
Compliance