Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "Accordion" component with customizable Inputs #851

Merged
merged 23 commits into from
Oct 6, 2023

Conversation

deeved-hiuston-brisa
Copy link
Contributor

@deeved-hiuston-brisa deeved-hiuston-brisa commented Sep 28, 2023

Issue Number

#849

Description

This Pull Request aims to add a new component called "Accordion" to our project. The "Accordion" component provides the ability to hide and show content with a collapse/expand feature. It comes with a set of customizable Inputs for greater usage flexibility.

Proposed Changes

  1. Addition of the "Accordion" component to the components directory.
  2. Definition of the following Inputs for the "Accordion" component:
  • @input() name?: string. This Input allows associating a name with the component, making it more identifiable and useful in contexts where multiple "Accordion" components may be used.
  • @input() templateHeader: TemplateHeader. This Input allows providing a custom TemplateHeader for the header of the "Accordion" component, giving the freedom to customize the header's appearance.
  • @input() show? = false. This Input controls the display state of the content within the "Accordion" component. When set to true, the content is displayed; otherwise, it remains hidden by default.
  1. Creation of unit tests to ensure the correct functioning of the "Accordion" component and its customizable Inputs.
  2. Addition of comprehensive documentation using Storybook for the "CoAccordionlapse" component, demonstrating how to use it with examples and usage scenarios.

Motivation

The addition of this new "Accordion" component with customizable Inputs will enhance the flexibility and usability of our project, enabling developers to create more dynamic and appealing user interfaces.

How to Test

To test the "Accordion" component, please follow the instructions in the Storybook and utilize the provided unit tests in this Pull Request.

View Storybook

Accordion

@deeved-hiuston-brisa deeved-hiuston-brisa linked an issue Sep 28, 2023 that may be closed by this pull request
Copy link
Contributor

@alysson-mascarenhas-brisa alysson-mascarenhas-brisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was very good and easy to use. Congratulations on the work!

@deeved-hiuston-brisa deeved-hiuston-brisa changed the title Add new "Collapse" component with customizable Inputs Add new "Accordion" component with customizable Inputs Oct 2, 2023
Copy link
Member

@iurynogueira iurynogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@deeved-hiuston-brisa deeved-hiuston-brisa self-assigned this Oct 3, 2023
@iurynogueira iurynogueira merged commit c79e112 into main Oct 6, 2023
3 checks passed
@iurynogueira iurynogueira deleted the 849-collapse branch October 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse
4 participants