Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ion tooltip close on scroll #848

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: ion tooltip close on scroll #848

merged 2 commits into from
Sep 28, 2023

Conversation

allan-chagas-brisa
Copy link
Contributor

Issue Number

fix #847

Proposed Changes

  • Added a host listenner to the scroll event of the window.

How to Test

yarn test tooltip

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

@allan-chagas-brisa allan-chagas-brisa linked an issue Sep 27, 2023 that may be closed by this pull request
fix: ion tooltip should close when user scrolls the page #847
Closed
@allan-chagas-brisa allan-chagas-brisa self-assigned this Sep 27, 2023
@allan-chagas-brisa allan-chagas-brisa merged commit 88d3bd9 into main Sep 28, 2023
3 checks passed
@allan-chagas-brisa allan-chagas-brisa deleted the 847-fix-ion-tooltip-should-close-when-user-scrolls-the-page branch September 28, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-moreira-brisa danilo-moreira-brisa danilo-moreira-brisa approved these changes

@iurynogueira iurynogueira iurynogueira approved these changes

@lucas-alcantara-brisa lucas-alcantara-brisa Awaiting requested review from lucas-alcantara-brisa

@deeved-hiuston-brisa deeved-hiuston-brisa Awaiting requested review from deeved-hiuston-brisa

@pedro-martins-brisa pedro-martins-brisa Awaiting requested review from pedro-martins-brisa

@alysson-mascarenhas-brisa alysson-mascarenhas-brisa Awaiting requested review from alysson-mascarenhas-brisa

@wermeson-lopes-brisa wermeson-lopes-brisa Awaiting requested review from wermeson-lopes-brisa

Assignees

@allan-chagas-brisa allan-chagas-brisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ion tooltip should close when user scrolls the page
3 participants
@allan-chagas-brisa @iurynogueira @danilo-moreira-brisa