Tooltip auto position #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-moreira-brisa
suggested changes
Sep 6, 2023
allan-chagas-brisa
requested review from
danilo-moreira-brisa,
allan-chagas-brisa and
lucas-alcantara-brisa
lucas-alcantara-brisa
approved these changes
Sep 13, 2023
danilo-moreira-brisa
suggested changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
fix #801
Description
It was required that the tooltip adjusted its position depending on the space it has avaliable, so I created a service with a subject to facilitate the comunication between the the directive and the component, so when the component verify the space around the host it notify the service so the directive knows if it has to call again the setPosition to fix the tooltip position.
How to Test
yarn test tooltip
Compliance