383 notification service (#736) #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add home icon * feat: add new icon #594 * refactor: replacing config2 icon #594 * feat: #383 creating notification service * feat: #383 ajusting width * feat: #383 updating public-api * feat: inserting notification service in storybooks and separating the notification component * fix: lint --------- Co-authored-by: Lucas <[email protected]> Co-authored-by: Alysson Keysson <[email protected]> Co-authored-by: Alysson Keysson <[email protected]>
Deeved
reviewed
Jul 27, 2023
iurynogueira
requested changes
Jul 31, 2023
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.ts
Outdated
Show resolved
Hide resolved
|
A error happen when notification close 
|
iurynogueira
requested changes
Aug 4, 2023
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/ion/src/lib/notification/service/notification.service.ts
Outdated
Show resolved
Hide resolved
added 2 commits
August 4, 2023 13:57
…t/ion into ion-notification-service
AlyssonMascarenhas
assigned AlyssonMascarenhas and lucas-alcantara-brisa and unassigned lucas-alcantara-brisa and AlyssonMascarenhas
iurynogueira
requested changes
Sep 11, 2023
projects/ion/src/lib/notification/service/notification.service.ts
Outdated
Show resolved
Hide resolved
iurynogueira
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a notification service
Proposed Changes
How to Test
Implements the notification service
Screenshots
Include screenshots or GIFs that illustrate the proposed changes. This can be especially useful for user interface changes.
View Storybook
https://62eab350a45bdb0a5818520e-bfcpynydxb.chromatic.com/?path=/story/ion-feedback-notification--service
Compliance