Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notifications limit option #1192

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat: add notifications limit option #1192

merged 2 commits into from
Nov 18, 2024

Conversation

allan-chagas-brisa
Copy link
Contributor

@allan-chagas-brisa allan-chagas-brisa commented Nov 13, 2024 •
edited
Loading

Issue Number

fix #1188

Description

It was required for the notification service to have a limit on the stack of notifications.

Proposed Changes

  • Added a config property to the service;
  • added a control array and a validation to the notification container, so it will close the first notification if the control array is at its max length.

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

@allan-chagas-brisa allan-chagas-brisa linked an issue Nov 13, 2024 that may be closed by this pull request
feat: add notifications limit option #1188
Closed
@allan-chagas-brisa allan-chagas-brisa changed the title feat add notifications limit option feat: add notifications limit option Nov 13, 2024
@allan-chagas-brisa allan-chagas-brisa self-assigned this Nov 13, 2024
@allan-chagas-brisa allan-chagas-brisa marked this pull request as draft November 14, 2024 11:54
@allan-chagas-brisa allan-chagas-brisa marked this pull request as ready for review November 14, 2024 14:14
@allan-chagas-brisa allan-chagas-brisa removed WIP Work in progress don't merge labels Nov 14, 2024
@allan-chagas-brisa allan-chagas-brisa merged commit 9c2ed06 into main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro-martins-brisa pedro-martins-brisa pedro-martins-brisa approved these changes

@larissa-kamily-brisa larissa-kamily-brisa larissa-kamily-brisa approved these changes

@lucas-alcantara-brisa lucas-alcantara-brisa lucas-alcantara-brisa approved these changes

@iurynogueira iurynogueira Awaiting requested review from iurynogueira

@deeved-hiuston-brisa deeved-hiuston-brisa Awaiting requested review from deeved-hiuston-brisa

@marcos-assis-brisa marcos-assis-brisa Awaiting requested review from marcos-assis-brisa

@jairo-chaves-brisa jairo-chaves-brisa Awaiting requested review from jairo-chaves-brisa

@yuri-silva-brisa yuri-silva-brisa Awaiting requested review from yuri-silva-brisa

@vinicius-guedes-brisa vinicius-guedes-brisa Awaiting requested review from vinicius-guedes-brisa

@matheus-maximiano-brisa matheus-maximiano-brisa Awaiting requested review from matheus-maximiano-brisa

@wermeson-lopes-brisa wermeson-lopes-brisa Awaiting requested review from wermeson-lopes-brisa

@lucas-emmanuel-brisa lucas-emmanuel-brisa Awaiting requested review from lucas-emmanuel-brisa

@edson-nunes-brisa edson-nunes-brisa Awaiting requested review from edson-nunes-brisa

@madalena-campos-brisa madalena-campos-brisa Awaiting requested review from madalena-campos-brisa

Assignees

@allan-chagas-brisa allan-chagas-brisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add notifications limit option
4 participants
@allan-chagas-brisa @lucas-alcantara-brisa @larissa-kamily-brisa @pedro-martins-brisa