Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved away from Gitbook and towards manual generation. #22

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

malavv
Copy link
Contributor

@malavv malavv commented Nov 16, 2022

Gitbook was initially a great choice for self-publishing of multi-authored technical documentation, yet changes made it less suitable for the Brewtarget user manual.

Some of this evolution is in #20 .

Nevertheless, this PR aims to gain back some of the missing functionalities by moving away from Gitbook build process to a locally buildable book. The choice of hosting platform will be eased by having a clear and simple build procedure.

@malavv malavv requested a review from mikfire November 16, 2022 04:58
@malavv
Copy link
Contributor Author

malavv commented Nov 16, 2022

Also while writing this PR, I realize some of the questions were about the link to the user manual from the Brewtarget website. I do not have any control over it. If a new hosting is chosen, the link may be readjusted. Or maybe a link to the "Release" section of this Github? Either way.

Copy link
Contributor

@mikfire mikfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maxime, nice to see you back. I am approving this but would request another PR to update the Brewtarget version. You are showing 2.3, and I think they've just released 3.0.2

@mikfire mikfire merged commit a1c9b04 into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants