Error recovery for string-in-boolean field in DB #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
src/database/ObjectStore.cppso that it can recover from the case where it finds a "true" or "false" string in a table field where it was expecting a boolean (or actually a 0 or 1, since SQLite doesn't have native booleans).I'm not sure how we end up with a string in a boolean field, but it can happen -- see #766. Given that we can automatically recover (provided the string holds something sane), we should.
I've tested this locally by manually modifying my DB but, as ever, any corrections or comments are welcome!