add login error alert popup

BrentMifsud · Jun 2, 2019 · 91b0fbe · 91b0fbe
1 parent 42fc3a3
commit 91b0fbe
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 10 deletions.
diff --git a/TheMovieManager/Controller/LoginViewController.swift b/TheMovieManager/Controller/LoginViewController.swift
@@ -50,6 +50,12 @@ class LoginViewController: UIViewController {
 		loginButton.isEnabled = !loggingIn
 		loginViaWebsiteButton.isEnabled = !loggingIn
 	}
+
+	func showLoginFailure(message: String) {
+		let alertVC = UIAlertController(title: "Login Failed", message: message, preferredStyle: .alert)
+		alertVC.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
+		show(alertVC, sender: nil)
+	}
 
 }
 
@@ -59,7 +65,7 @@ extension LoginViewController {
 			TMDBClient.login(username: self.emailTextField.text ?? "", password: self.passwordTextField.text ?? "", completion: self.handleLoginResponse(success:error:))
 		} else {
 			setLoggingIn(false)
-			print(error ?? "Get Request Token Failed")
+			showLoginFailure(message: error?.localizedDescription ?? "")
 		}
 	}
 
@@ -68,7 +74,7 @@ extension LoginViewController {
 			TMDBClient.getSessionId(completion: self.handleSessionIDResponse(success:error:))
 		} else {
 			setLoggingIn(false)
-			print(error ?? "Get Request Token Failed")
+			showLoginFailure(message: error?.localizedDescription ?? "")
 		}
 	}
 
@@ -77,7 +83,7 @@ extension LoginViewController {
 		if success {
 			self.performSegue(withIdentifier: "completeLogin", sender: nil)
 		} else {
-			print(error ?? "Get Session ID Failed")
+			showLoginFailure(message: error?.localizedDescription ?? "")
 		}
 	}
 }
diff --git a/TheMovieManager/Controller/WatchlistViewController.swift b/TheMovieManager/Controller/WatchlistViewController.swift
@@ -18,7 +18,7 @@ class WatchlistViewController: UIViewController {
         super.viewDidLoad()
 
         _ = TMDBClient.getWatchlist() { movies, error in
-            MovieModel.watchlist = movies
+			MovieModel.watchlist = movies
             DispatchQueue.main.async {
                 self.tableView.reloadData()
             }

diff --git a/TheMovieManager/Model/TMDB Client/TMDBClient.swift b/TheMovieManager/Model/TMDB Client/TMDBClient.swift
@@ -119,7 +119,7 @@ class TMDBClient {
 				Auth.requestToken = response.requestToken
 				completion(true, nil)
 			} else {
-				completion(false, nil)
+				completion(false, error)
 			}
 		}
 	}
@@ -196,10 +196,16 @@ extension TMDBClient {
 					completion(responseObject, nil)
 				}
 			} catch {
-				DispatchQueue.main.async {
-					completion(nil, error)
+				do {
+					let errorResponse = try decoder.decode(TMDBResponse.self, from: data) as Error
+					DispatchQueue.main.async {
+						completion(nil, errorResponse)
+					}
+				} catch {
+					DispatchQueue.main.async {
+						completion(nil, error)
+					}
 				}
-
 			}
 		}
 		task.resume()
@@ -226,8 +232,15 @@ extension TMDBClient {
 					completion(responseObject, nil)
 				}
 			} catch {
-				DispatchQueue.main.async {
-					completion(nil, error)
+				do {
+					let errorResponse = try decoder.decode(TMDBResponse.self, from: data) as Error
+					DispatchQueue.main.async {
+						completion(nil, errorResponse)
+					}
+				} catch {
+					DispatchQueue.main.async {
+						completion(nil, error)
+					}
 				}
 			}
 		}

diff --git a/TheMovieManager/Model/TMDB Responses/TMDBResponse.swift b/TheMovieManager/Model/TMDB Responses/TMDBResponse.swift
@@ -27,3 +27,9 @@ struct TMDBResponse: Codable {
 	}
 
 }
+
+extension TMDBResponse: LocalizedError {
+	var errorDescription: String? {
+		return self.statusMessage
+	}
+}