Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize matcher #85

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Maximize matcher #85

merged 8 commits into from
Jan 15, 2024

Conversation

Hendrik-code
Copy link
Collaborator

adding the maximizeMatcher which matches the following:

  • For each reference, links the prediction instance with best score that beats threshold
  • Iteratively for the rest, checks if combining the current prediction instance with the second prediction instance makes the matching score better. If yes, merge prediction instances. Otherwise, continue
  • results in many-to-one matching scheme.

@Hendrik-code Hendrik-code self-assigned this Jan 15, 2024
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code Hendrik-code linked an issue Jan 15, 2024 that may be closed by this pull request
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 I will now format your code with black. Check the status here.

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 I will now format your code with black. Check the status here.

@Hendrik-code Hendrik-code merged commit 4ce4a80 into main Jan 15, 2024
4 checks passed
@Hendrik-code Hendrik-code deleted the maximize_matcher branch January 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] MaximizeIouMany2OneMatcher
1 participant