Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular metrics #71

Merged
merged 20 commits into from
Jan 15, 2024
Merged

Modular metrics #71

merged 20 commits into from
Jan 15, 2024

Conversation

Hendrik-code
Copy link
Collaborator

No description provided.

@neuronflow
Copy link
Contributor

Probably we should close the pr until it is ready to merge?

@neuronflow
Copy link
Contributor

ouch we now have conflicts with main here 🙈

@neuronflow neuronflow marked this pull request as draft December 15, 2023 19:30
@Hendrik-code Hendrik-code marked this pull request as ready for review January 12, 2024 14:46
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 12, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 12, 2024

🤖 I will now format your code with black. Check the status here.

Copy link
Contributor

@neuronflow neuronflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

@@ -21,7 +21,7 @@
expected_input=SemanticPair,
instance_approximator=ConnectedComponentsInstanceApproximator(),
instance_matcher=NaiveThresholdMatching(),
iou_threshold=0.5,
match_threshold=0.5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be called match or matching threshold?

@@ -89,7 +89,7 @@ def test_input(processing_pair: SemanticPair):
#
start3 = perf_counter()
processing_pair = evaluate_matched_instance(
processing_pair, iou_threshold=iou_threshold
processing_pair, matching_threshold=iou_threshold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match or matching?

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 15, 2024

🤖 I will now format your code with black. Check the status here.

@Hendrik-code Hendrik-code merged commit 69beab8 into main Jan 15, 2024
4 checks passed
@Hendrik-code Hendrik-code deleted the modular_metrics branch January 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] modular metrics [feature request] matching via different similarity metrics
2 participants