-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular metrics #71
Modular metrics #71
Conversation
Signed-off-by: neuronflow <[email protected]>
…s matching metric and threshold to make evaluator give a better overview
Signed-off-by: neuronflow <[email protected]>
Signed-off-by: neuronflow <[email protected]>
Probably we should close the pr until it is ready to merge? |
ouch we now have conflicts with main here 🙈 |
…ed string and dict representation
/format |
🤖 I will now format your code with black. Check the status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm
examples/example_cfos_3d.py
Outdated
@@ -21,7 +21,7 @@ | |||
expected_input=SemanticPair, | |||
instance_approximator=ConnectedComponentsInstanceApproximator(), | |||
instance_matcher=NaiveThresholdMatching(), | |||
iou_threshold=0.5, | |||
match_threshold=0.5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be called match or matching threshold?
benchmark/modules_speedtest.py
Outdated
@@ -89,7 +89,7 @@ def test_input(processing_pair: SemanticPair): | |||
# | |||
start3 = perf_counter() | |||
processing_pair = evaluate_matched_instance( | |||
processing_pair, iou_threshold=iou_threshold | |||
processing_pair, matching_threshold=iou_threshold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
match or matching?
/format |
🤖 I will now format your code with black. Check the status here. |
No description provided.