Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config #115

Merged
merged 15 commits into from
Aug 6, 2024
Merged

Config #115

merged 15 commits into from
Aug 6, 2024

Conversation

Hendrik-code
Copy link
Collaborator

@Hendrik-code Hendrik-code commented Aug 2, 2024 •
edited
Loading

THIS WILL INTRODUCE BREAKING CHANGES!

New feature:
Configuration files via ruamel
You can load and save objects with yaml objects using the newly added "SupportsConfig" superclass. For Enums, this has also been introduced.

Endgoal: You can save every evaluator-relevant part or subpart to configs and load it from there.

@Hendrik-code Hendrik-code added the enhancement New feature or request label Aug 2, 2024
@Hendrik-code Hendrik-code self-assigned this Aug 2, 2024
@Hendrik-code Hendrik-code linked an issue Aug 2, 2024 that may be closed by this pull request
Add function that lets you create panoptica evaluator objects from config files #106
Closed
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@Hendrik-code Hendrik-code requested a review from neuronflow August 5, 2024 11:48
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 I will now format your code with black. Check the status here.

@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@BrainLesion BrainLesion deleted a comment from brainless-bot bot Aug 5, 2024
@Hendrik-code Hendrik-code marked this pull request as ready for review August 5, 2024 11:48
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 I will now format your code with black. Check the status here.

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 5, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

neuronflow
neuronflow approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@neuronflow neuronflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, things become fancy :)

@neuronflow neuronflow merged commit 50889d3 into main Aug 6, 2024
4 checks passed
@neuronflow neuronflow deleted the config branch August 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuronflow neuronflow neuronflow approved these changes

Assignees

@Hendrik-code Hendrik-code

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add function that lets you create panoptica evaluator objects from config files
2 participants
@Hendrik-code @neuronflow