-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a whole bunch of default values #59
Conversation
Signed-off-by: neuronflow <[email protected]>
/format |
🤖 I will now format your code with black. Check the status here. |
can you open a feature request so we don't lose track of this? @sarthakpati |
@sarthakpati currently, unit tests are not passing yet. |
once this passes unit tests and is merged, we can merge #57 to require passed tests before merging, so we don't break ereg again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about putting default values in a yaml file to create a single source of truth?
…n/eReg into 56-keyerror-metric
Sure, but let's tie it in with #60. Doing yaml I/O in a purely computational class is just clunky. |
I am pretty sure there is a better way to do this (for example, having a base
Config
class underereg.configurations
that reads thesample_config.yaml
and populates a baselineConfig
object, which can then be used in theRegistrationClass
class.However, I unfortunately don't have the kind of time on hand right now to make this change. I would really appreciate it if someone could help me put this together.
Includes #57, so that should/will get merged along with this.