Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP 26 compat: fix ssl options on Tesla request #3

Merged
merged 8 commits into from
Mar 22, 2024

Conversation

tfiedlerdejanze
Copy link
Member

@tfiedlerdejanze tfiedlerdejanze commented Mar 22, 2024

I have tested this with localstack against sched on OTP 26 and confirmed it's working.

@tfiedlerdejanze
Copy link
Member Author

@aaronrenner @edennis looks like the index we're using to run the tests is full :(

@tfiedlerdejanze tfiedlerdejanze changed the title CI: use uptodate elixir/otp versions OTP 26 compat: fix ssl options on Tesla request Mar 22, 2024
lib/algolia.ex Outdated Show resolved Hide resolved
@aaronrenner
Copy link
Member

It looks like there are a couple issues...

  1. The test suite appears to not be cleaning up after itself and we're running out of indexes. We should probably address this separately.
  2. I'm seeing a couple SSL related warnings in our test output:
Warning: 13:08:56.520 [warning] Description: ~c"Server authenticity is not verified since certificate path validation is not enabled"
     Reason: ~c"The option {verify, verify_peer} and one of the options 'cacertfile' or 'cacerts' are required to enable this."

This will be a great change, but we should probably get these resolved first.

@tfiedlerdejanze tfiedlerdejanze merged commit d255b8d into develop Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants