Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace example images with gif from terminalizer #185

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

jackneer
Copy link
Contributor

@kehoecj

This PR is for the issue #175. I replaced images of examples with a gif image generated from terminalizer. please review, thanks!

@kehoecj kehoecj self-requested a review October 21, 2024 14:13
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackneer Rather than a single gif that goes through everything I'd like one under each example section

@kehoecj kehoecj added hacktoberfest-accepted Valid PR Hacktoberfest PR hacktoberfest 🎃 Hacktoberfest 2024 pr-action-requested PR is awaiting feedback from the submitting developer labels Oct 21, 2024
@kehoecj
Copy link
Collaborator

kehoecj commented Oct 23, 2024

@jackneer Please resolve conflicts

@jackneer
Copy link
Contributor Author

@jackneer Rather than a single gif that goes through everything I'd like one under each example section

got it

@jackneer jackneer force-pushed the show-examples-with-terminalizer branch from 7861dc6 to 12ac539 Compare October 26, 2024 05:35
@jackneer
Copy link
Contributor Author

@kehoecj I separated example images and resolved conflict. please review, thanks!

@kehoecj kehoecj self-requested a review October 28, 2024 13:58
@kehoecj kehoecj merged commit 9069d05 into Boeing:main Oct 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest 🎃 Hacktoberfest 2024 hacktoberfest-accepted Valid PR Hacktoberfest PR pr-action-requested PR is awaiting feedback from the submitting developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants