Add globbing pattern matching for search_path #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehoecj
added
hacktoberfest-accepted
|
@anya004 Thank you for the PR! Implementation looks good. Can you please take a loot at the golangci-lint findings? |
kehoecj
reviewed
Oct 11, 2024
kehoecj
reviewed
Oct 11, 2024
kehoecj
added
pr-action-requested
anya004
force-pushed
the
add-globbing
branch
2 times, most recently
from
e7114ee
to
b18647a
Compare
|
@anya004 Please resolve conflicts |
|
@anya004 I'd like to get you merged in before Hacktoberfest is over. Please take a look at the the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
This PR adds support for glob patterns, controlled by a new
globbingflag. When enabled (-globbing), the tool will use glob pattern matching to locate files and directories.I decided to implement a flag so that the user is aware of the behaviour in case they have some unconventional filenames.
When globbing is enabled, matched paths are dynamically added to the
searchPatharray for further processing.