-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display excludeable file types and validate #178
Conversation
@danielingegneri Thanks for the PR! Love the implementation. Looks like there is a goreportcard issue around the complexity in the |
…nts and flag usages; moved to caller, and made the flags a var block. Unfortunately not able to get complexity below 17.
Attempted to reduce complexity. Mostly by simplifying validation more. Also noticed the messages being printed on validation error, and the error being returned, were repeats. Suggest instead displaying the error text in thrown error. |
Is it preferred that I undo the additional logging changes made, and keep to minimum? |
@danielingegneri I'm willing to push your change for now and deal with refactoring later to get the complexity down a bit. Let me do a final review and if everything looks good I'll merge it. |
@danielingegneri Let me know when this is ready for another review. Looks like a merge conflict and just one comment needs to be resolved before we can merge this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sorted the list, added space after comma, does look nicer now :)
First pull req, plz let me know if needs work. #170